Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move abi utils to snapi #2105

Merged
merged 1 commit into from
Nov 18, 2024
Merged

chore: move abi utils to snapi #2105

merged 1 commit into from
Nov 18, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Nov 17, 2024 •
edited
Loading

In this PR we move code from the blockifier crate, the abi folder, into starknet_api.

Specifically:
0. Split the model crates/blockifier/src/abi.rs. The other part is moved to crates/starknet_api/src/abi.rs.

  1. Split the file: crates/blockfier/src/abi/constants.rs. The other part is moved to crates/starknet_api/src/abi/constants.rs.
  2. The file: crates/blockifier/src/abi/abi_utils.rs is moved to crates/starknet_api/src/abi/abi_utils.rs (with the corresponding test util).

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Nov 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 17, 2024
Merged
Merged
Merged
@ArniStarkware ArniStarkware marked this pull request as ready for review November 17, 2024 11:30
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.436 ms 29.483 ms 29.537 ms]
change: [-1.8129% -1.6018% -1.3936%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/snapi/share_transaction_constants branch from d4c55e7 to 8fa9411 Compare November 17, 2024 11:43
@ArniStarkware ArniStarkware force-pushed the arni/snapi/move_abi_from_blockifier branch from 77ed7da to 3569518 Compare November 17, 2024 11:43
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.394 ms 29.435 ms 29.482 ms]
change: [-1.6899% -1.4896% -1.2982%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/snapi/share_transaction_constants branch from 8fa9411 to fa4cc11 Compare November 17, 2024 11:54
@ArniStarkware ArniStarkware force-pushed the arni/snapi/move_abi_from_blockifier branch from 3569518 to 36e1f11 Compare November 17, 2024 11:54
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware force-pushed the arni/snapi/move_abi_from_blockifier branch from 36e1f11 to 4320c8b Compare November 17, 2024 12:01
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.745 ms 33.909 ms 34.168 ms]
change: [-5.6131% -4.0601% -2.6076%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe

full_committer_flow performance improved 😺
full_committer_flow time: [29.432 ms 29.468 ms 29.505 ms]
change: [-1.9002% -1.7121% -1.5236%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (e3165c4) to head (fafad83).
Report is 461 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2105       +/-   ##
===========================================
+ Coverage   40.10%   77.35%   +37.24%     
===========================================
  Files          26      382      +356     
  Lines        1895    40219    +38324     
  Branches     1895    40219    +38324     
===========================================
+ Hits          760    31110    +30350     
- Misses       1100     6817     +5717     
- Partials       35     2292     +2257

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/snapi/move_abi_from_blockifier branch from 4320c8b to 0964710 Compare November 17, 2024 12:28
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.430 ms 29.470 ms 29.516 ms]
change: [-2.6603% -1.8815% -1.3924%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) low mild
3 (3.00%) high mild
2 (2.00%) high severe

MohammadNassar1
MohammadNassar1 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 34 of 50 files at r1, 18 of 18 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)

@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Nov 18, 2024 •
edited
Loading

Merge activity

  • Nov 18, 4:38 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 18, 4:40 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 18, 5:59 AM EST: A user merged this pull request with Graphite.

@ArniStarkware ArniStarkware changed the base branch from arni/snapi/share_transaction_constants to graphite-base/2105 November 18, 2024 09:39
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2105 to main November 18, 2024 09:39
@ArniStarkware ArniStarkware force-pushed the arni/snapi/move_abi_from_blockifier branch from 0964710 to fafad83 Compare November 18, 2024 09:39
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.352 ms 29.389 ms 29.426 ms]
change: [-2.3969% -1.8917% -1.5145%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

ArniStarkware
ArniStarkware commented Nov 18, 2024
View reviewed changes
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware and @MohammadNassar1)

@ArniStarkware ArniStarkware merged commit e0acf62 into main Nov 18, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ayeletstarkware ayeletstarkware Awaiting requested review from ayeletstarkware

@MohammadNassar1 MohammadNassar1 Awaiting requested review from MohammadNassar1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @reviewable-StarkWare @MohammadNassar1